Skip to content

Commit

Permalink
floppy: cleanup: make twaddle() not rely on current_{fdc,drive} anymore
Browse files Browse the repository at this point in the history
Now the fdc and drive are passed in argument so that the function does
not use current_fdc nor current_drive anymore.

Link: https://lore.kernel.org/r/20200331094054.24441-10-w@1wt.eu
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Denis Efremov <efremov@linux.com>
  • Loading branch information
wtarreau authored and evdenis committed May 12, 2020
1 parent 38ede90 commit c1f710b
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/block/floppy.c
Original file line number Diff line number Diff line change
Expand Up @@ -827,14 +827,14 @@ static int set_dor(int fdc, char mask, char data)
return olddor;
}

static void twaddle(void)
static void twaddle(int fdc, int drive)
{
if (drive_params[current_drive].select_delay)
if (drive_params[drive].select_delay)
return;
fdc_outb(fdc_state[current_fdc].dor & ~(0x10 << UNIT(current_drive)),
current_fdc, FD_DOR);
fdc_outb(fdc_state[current_fdc].dor, current_fdc, FD_DOR);
drive_state[current_drive].select_date = jiffies;
fdc_outb(fdc_state[fdc].dor & ~(0x10 << UNIT(drive)),
fdc, FD_DOR);
fdc_outb(fdc_state[fdc].dor, fdc, FD_DOR);
drive_state[drive].select_date = jiffies;
}

/*
Expand Down Expand Up @@ -1934,7 +1934,7 @@ static void floppy_ready(void)
"calling disk change from floppy_ready\n");
if (!(raw_cmd->flags & FD_RAW_NO_MOTOR) &&
disk_change(current_drive) && !drive_params[current_drive].select_delay)
twaddle(); /* this clears the dcl on certain
twaddle(current_fdc, current_drive); /* this clears the dcl on certain
* drive/controller combinations */

#ifdef fd_chose_dma_mode
Expand Down Expand Up @@ -2904,7 +2904,7 @@ static void redo_fd_request(void)
}

if (test_bit(FD_NEED_TWADDLE_BIT, &drive_state[current_drive].flags))
twaddle();
twaddle(current_fdc, current_drive);
schedule_bh(floppy_start);
debugt(__func__, "queue fd request");
return;
Expand Down Expand Up @@ -3610,7 +3610,7 @@ static int fd_locked_ioctl(struct block_device *bdev, fmode_t mode, unsigned int
case FDTWADDLE:
if (lock_fdc(drive))
return -EINTR;
twaddle();
twaddle(current_fdc, current_drive);
process_fd_request();
return 0;
default:
Expand Down

0 comments on commit c1f710b

Please sign in to comment.