Skip to content

Commit

Permalink
oprofile: Replace zero-length array with flexible-array
Browse files Browse the repository at this point in the history
There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] KSPP/linux#21

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
  • Loading branch information
GustavoARSilva committed Jun 16, 2020
1 parent 8a631c2 commit 0a418cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/oprofile/cpu_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ void flush_cpu_work(void);
struct op_sample {
unsigned long eip;
unsigned long event;
unsigned long data[0];
unsigned long data[];
};

struct op_entry;
Expand Down

0 comments on commit 0a418cd

Please sign in to comment.