Skip to content

Fix building with Windows SDK and Clang-CL #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Fix building with Windows SDK and Clang-CL #7337

merged 5 commits into from
Aug 15, 2024

Conversation

Naville
Copy link
Contributor

@Naville Naville commented Aug 12, 2024

This maybe fixes #7318

Definitely need a second pair of eyes to review, and maybe CI for testing

@Naville
Copy link
Contributor Author

Naville commented Aug 13, 2024

I don't really understand why

set(CMAKE_CXX_FLAGS_INIT "")
is required, and it hasn't been updated for 7 years

@NikolajBjorner NikolajBjorner merged commit c1454dc into Z3Prover:master Aug 15, 2024
17 of 20 checks passed
arbipher pushed a commit to arbipher/z3 that referenced this pull request Apr 17, 2025
* Fix building with Windows SDK and Clang-CL

* Attempt to add Clang-CL to CI build configurations

* Fix typo

* Enable EHsc explicitly when using ClangCL due to it being default turned-off

* Override CMAKE_<LANG>_FLAGS instead due to Z3 resets the _INIT variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__GNUC__ isn't always defined
2 participants