Check if $message returns false #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Released under the GNU Affero General Public License (AGPL), version 3.
|
Confirmed working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Released under the GNU Affero General Public License (AGPL), version 3.
What does this implement/fix? Explain your changes.
backend->GetMessage can return false instead of an object. Check before setting flag.
Does this close any currently open issues?
#5
Any relevant logs, error output, etc?
same as raised in issue
PHP message: PHP Fatal error: Uncaught Error: Attempt to assign property "flags" on bool in /z-push/lib/default/diffbackend/exportchangesdiff.p
hp:163
Where has this been tested?
Server (please complete the following information):
Smartphone (please complete the following information):
Recreated same issue as in Zimbra backend with CardDav backend. Likely affected all backends when returning false occurred.