Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substring is not a valid php function #1

Merged
merged 1 commit into from
Apr 6, 2023
Merged

substring is not a valid php function #1

merged 1 commit into from
Apr 6, 2023

Conversation

d0m84
Copy link
Contributor

@d0m84 d0m84 commented Sep 24, 2022

I saw that the development luckily continues :)
This is a small bugfix I have running for ages locally.

matidau pushed a commit that referenced this pull request Apr 6, 2023
…x-loss-of-content-with-outlook-and-koe

ZP-1615 BackendStickyNote: Fix loss of content with Outlook and KOE on ChangeMessage() without changes.
@matidau matidau merged commit 391a90a into Z-Hub:develop Apr 6, 2023
matidau pushed a commit that referenced this pull request Jun 2, 2023
PHP 8.0 stopped allowing empty strings to be passed to gmstrftime. This led to the previously suggested change to replace the empty string with null. Unfortunately, that change collided with the gmstrftime also accepting null as a valid input where it would return the current time formatted as requested.

This led to contacts who had empty Anniversary and Birthday fields getting their empty strings replaced by nulls, and subsequently getting passed to gmstrftime which would assign them values of the current time.

The correct behaviour for the streamer in this instance is to just return the empty string
mschering added a commit to Intermesh/Z-Push that referenced this pull request Apr 5, 2024
dallaslu added a commit to dallaslu/Z-Push that referenced this pull request Jul 4, 2024
fix: error `PHP message: PHP Fatal error:  Uncaught TypeError: strcasecmp(): Argument Z-Hub#1 ($string1) must be of type string`

There is `is_array($value)` in default case, so, it needs `is_string` to detect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants