Make previewChips use the grid system as well

[anthonyraymond]

Description

Before this PR previewGridProps and previewGridClasses had no effect if we switched to useChipsForPreview and all the chips got stacked one below the other because of the use of a simple div.

Using the already well established previewGrid props allow for much more chip customizations.

Chips are now displayed inline by default but thanks to the previewGridProps this can be changed at any time

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested

I've tested it personally in one of my projects

Test Configuration:

• Browser: Chrome

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[panz3r]

Hi @anthonyraymond ,

Thanks for your contribution, I'd ask a code review to @max-carroll because he recently worked on the Preview section of this module and probably he will need to change something in his open PR too.

[max-carroll]

Hi @panz3r I will have a look at this either tonight or first thing tomorrow

[max-carroll]

Looks good, however needs the latest changes pulled in (which I'm sorry which will require a small bit of extra work since I deprecated a few of the things you used)

[max-carroll]

Actually @panz3r I just noticed this is atop of master and not v4.x so this should be fine, however if this is to be merged into v4.x my changes will need to be considered, what do you think?

[max-carroll]

I suppose the other alternative is we cherry pick the change into v4.x and fix it where it's not as desired

[panz3r]

Actually @panz3r I just noticed this is atop of master and not v4.x so this should be fine, however if this is to be merged into v4.x my changes will need to be considered, what do you think?

I suppose that since we are going to consider the changes you made to the Preview section a breaking change (thus the v4.x target), any change made here that's no longer required with the new implementation will remain only on v3.x.

The idea being to leave behind a v3.x which behaves as best as possible for its current implementation while keeping on improving behaviour and design with 4.x (and later v5.x).

[max-carroll]

In that case I will change my review to "looks good"

[max-carroll]

In that case I will change my review to "looks good"

approve changes... sorry I have been institutionalised by TFS, if you ever see TFS anywhere, avoid it 🤣

[panz3r]

Hi @anthonyraymond ,

Thanks for your contribution and for your patience (also thanks to @max-carroll for reviewing the code 👍 ).

The PR looks good, as @max-carroll suggested could you please add a little example inside DropzoneAreaBase.md to have a demo that references your changes, thanks in advance.

⚠️ Waiting to merge this PR because there are some small bugfixes I'd like to include into v3.2 before moving to v3.3.

[anthonyraymond]

Hi guys, thanks for your review.

I've added an example, but honestly i don't know if such a small thing deserves a documentation, before that PR the previewChip system wasn't aware of the component properties, i've just used the already existing properties.