Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception raised when closing preferences #56

Merged
merged 1 commit into from
May 12, 2020

Conversation

Yutsuten
Copy link
Owner

Regression from #53 .
I was unable to close Anki in the usual way. Had to kill the process.

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/aqt/preferences.py", line 48, in reject
    self.accept()
  File "<decorator-gen-10>", line 2, in accept
  File "/usr/lib/python3.8/site-packages/anki/hooks.py", line 638, in decorator_wrapper
    return repl(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/anki/hooks.py", line 632, in repl
    new(*args, **kwargs)
  File "/home/mateus/.local/share/Anki2/addons21/lifedrain/main.py", line 48, in <lambda>
    Preferences.accept, lambda *args: lifedrain.preferences_save(args[0]),
  File "/home/mateus/.local/share/Anki2/addons21/lifedrain/lifedrain.py", line 77, in preferences_save
    conf = self._settings.preferences_save(pref)
  File "/home/mateus/.local/share/Anki2/addons21/lifedrain/settings.py", line 183, in preferences_save
    conf.pop('barBgColor', None)
AttributeError: 'ConfigManager' object has no attribute 'pop'

@Yutsuten Yutsuten added bug Something isn't working as expected critical Should be done ASAP labels May 12, 2020
@Yutsuten Yutsuten self-assigned this May 12, 2020
@Yutsuten Yutsuten merged commit 226e3c3 into master May 12, 2020
@Yutsuten Yutsuten deleted the fix/global-settings branch May 12, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected critical Should be done ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant