Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #41

Merged
merged 45 commits into from
Dec 3, 2019
Merged

Refactor #41

merged 45 commits into from
Dec 3, 2019

Conversation

Yutsuten
Copy link
Owner

@Yutsuten Yutsuten commented Nov 8, 2019

Resolves #25

Splitting into multiple scripts for better maintainability.

@Yutsuten Yutsuten added the code quality Improve the quality of the source code label Nov 8, 2019
@Yutsuten Yutsuten self-assigned this Nov 8, 2019
@Yutsuten
Small refactor on drain/recover
6146932
@Yutsuten
Rewrite one-line functions into lambdas
eaa60d4
@Yutsuten
Move business logic to lifedrain.py
42692b5 
main.py should only add hooks
@Yutsuten
Ignore anki 2.0 (for compatibility tests)
ca17f82
@Yutsuten
Move all hooks into main and organize it
340065f
@Yutsuten
Make some variables private
b32153f
@Yutsuten
Remove imports from anki in lifedrain.py
d34886d
@Yutsuten
Create SettingsUi class
e52ef8c
@Yutsuten
Fix bug when opening the color dialog
f02b82e
@Yutsuten
Move Settings usage to lifedrain.py
88debaa
@Yutsuten
Refactor settings.py
b4ad3c1
@Yutsuten
Move all config load & save to settings.py
d6654d1
@Yutsuten
Rename LifeDrain to Lifedrain
37f0753
@Yutsuten
Rename Deck to DeckManager
05c0691
@Yutsuten
Some refactor on DeckManager and ProgressBar
5339afc
@Yutsuten
Prevent dock widgets from being spammed
e1abe07
@Yutsuten
Refactor DeckManager
ecbdf1e
@Yutsuten
Prevent life from being drained when not reviewing
e425a51 
Clicking Study Now when there were no cards to review was triggering this
bug.
@Yutsuten
Refactor on screen_change method
5325563
@Yutsuten
Delete closed docks, dont create if place is same
9f61d50
@Yutsuten
Move ProgressBar private methods to the end
7301dda
@Yutsuten
Fix screen state getting wrong in some cases
1e0ae5b
@Yutsuten
Allow setting current life while reviewing
1b4d6ce
@Yutsuten
Improve logic of toggle drain on show answer
032dc7d
@Yutsuten
Remove unnecessary check on dock_at
23572d2
@Yutsuten
Remove unused import
0432b72
@Yutsuten
Simplify defaults.py script
565f57f
@Yutsuten
Put UI methods into lifedrain attributes
f67045c 
With some other miscellaneous refactorings
@Yutsuten
Fix error being raised while addon is disabled
5ffd7f7
@Yutsuten
Make deck_manager attribute public
7dc6b11
@Yutsuten
Check if add-on is enabled via decorator
fb96603
@Yutsuten
Refactor code that updates the progress bar style
2a01c54
@Yutsuten
Use setVisible to update progress bar visibility
7a45c4b
@Yutsuten
Change method name
1881378
@Yutsuten
Remove unnecessary condition check
53dcb30
@Yutsuten
Ignore pylint error on wrapper function
87332e3
@Yutsuten
Start changing docstring format to Google style
b2e25e5
@Yutsuten
Finish updating docstrings to Google Style
276a970
@Yutsuten
Small improvement on dock (separator) code
d24525e
@Yutsuten Yutsuten changed the title [WIP] Refactor Refactor Dec 3, 2019
@Yutsuten
Copy link
Owner Author

Yutsuten commented Dec 3, 2019

Much better now!

@Yutsuten Yutsuten merged commit 9e2fb19 into master Dec 3, 2019
@Yutsuten Yutsuten deleted the refactoring branch December 3, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yutsuten Yutsuten

Labels
code quality Improve the quality of the source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move classes and related functions into separated scripts
1 participant
@Yutsuten