Smooth life drain #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still some bugs to be fixed though...
|
Feels good now, will test locally these changes for some days to be sure that nothing is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39
Seems that QProgressBar does not accept float values, so I had to increase the max value and keep each drain removing 1 unit. I increased the drain frequency to 10 times/sec and increased the max life by 10.
With this, the automatically generated text inside the bar does not show the value in seconds anymore, so I'll have to fix this with some workaround.
Also there are problems when restoring the current life when changing decks.
The objective is to keep everything working the same as it is in the last released version, but make the life be smoothly drained.