[Ports]: Backport client side changes for 1.62 - #391
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #389
Summary
Locator#wait_for_function, actionscroll, URL glob normalization, WebP screenshots, timeout protocol metadata,APIResponse#timing, and screencast frame acknowledgements_trackimplementation/specs and the Chromium JS coverage case deleted upstreamRSpec fidelity
The new and changed RSpec examples were compared directly with the v1.62.1 upstream tests. Test names, inputs, and assertions are preserved where the Ruby API supports them; only language-specific adaptations were made. JavaScript-only AbortSignal cases were intentionally excluded. Tests deleted upstream by #41581 and #41303 were removed rather than weakened.
Verification
git diff --checkbundle exec rake build