Use playwright-core instead of standalone driver - #390
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-corenpm installsdevelopment/api.jsonfrom the exact upstream Playwright source commit recorded in npm metadatanode_modules/.bin/playwright-coredevelopment/update_playwright_driver.shWhy
microsoft/playwright#41518 removed standalone driver publishing and the hidden
print-api-jsonCLI command. Releases after that change can no longer use the CDN/CLI workflow in this repository.The new API generator resolves
playwright-core@<version>to its exactgitHead, sparse-checks out only upstreamutils/anddocs/, and atomically updatesdevelopment/api.jsonafter validating the generated JSON.This is a prerequisite for #389 and intentionally keeps the repository on the existing Playwright 1.61.1 baseline.
User and developer impact
Node.js and npm are now required. Install the compatible
playwright-coreversion and passnode_modules/.bin/playwright-coreasplaywright_cli_executable_path. Direct standalone driver downloads are no longer documented or supported.Validation
development/generate_api_json.shreproduced the committed Playwright 1.61.1development/api.jsonwithout a diffplaywright-core@1.61.1reported the expected version and passedspec/integration/browser_spec.rbon Chromium: 2 examples, 0 failuresspec/playwright_spec.rb: 2 examples, 0 failuresgit diff --checkvalidation passedThe full RSpec matrix is intentionally left to CI because it is slow locally.