Skip to content

deflack web_socket_spec #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YusukeIwaki merged 1 commit into from
Apr 2, 2026
Merged

deflack web_socket_spec #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions spec/integration/web_socket_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,18 @@

it 'should reject waitForEvent on socket close', sinatra: true do
with_page do |page|
incoming_frame = Concurrent::Promises.resolvable_future
page.on('websocket', ->(web_socket) {
web_socket.on('framereceived', ->(_) {
incoming_frame.fulfill(web_socket) unless incoming_frame.resolved?
})
})

ws = page.expect_websocket do
page.evaluate("window.ws = new WebSocket('#{ws_url}')")
end
ws.wait_for_event('framereceived')
expect(incoming_frame.value!).to eq(ws)

expect {
ws.expect_event('framesent') do
page.evaluate('window.ws.close()')
Expand All @@ -142,10 +150,18 @@

it 'should reject waitForEvent on page close', sinatra: true do
with_page do |page|
incoming_frame = Concurrent::Promises.resolvable_future
page.on('websocket', ->(web_socket) {
web_socket.on('framereceived', ->(_) {
incoming_frame.fulfill(web_socket) unless incoming_frame.resolved?
})
})

ws = page.expect_websocket do
page.evaluate("window.ws = new WebSocket('#{ws_url}')")
end
ws.wait_for_event('framereceived')
expect(incoming_frame.value!).to eq(ws)

expect {
ws.expect_event('framesent') do
page.close
Expand Down
Loading