Skip to content

Automatically flag apps as deprecated-software with the help of a crappy script#2103

Closed
Salamandar wants to merge 7 commits intomasterfrom
deprecated
Closed

Automatically flag apps as deprecated-software with the help of a crappy script#2103
Salamandar wants to merge 7 commits intomasterfrom
deprecated

Conversation

@Salamandar
Copy link
Contributor

tl;dr, only working for github upstreams, checks if the latest commit is more than 1 year old

@zamentur
Copy link
Member

zamentur commented Mar 7, 2024

For me we can remove from this list a lot of html/js apps (without server side code). Specifically all games.

So at least: 20euros, 243-game, hextris, anarchism, cubiks-2048, encryptor-decryptor, filepizza, hat, osjs, simple-hash-generator, strut, trustyhash, tyto

Those apps are not really deprecated, those apps are finished and doesn't really need update for now.

@orhtej2
Copy link
Contributor

orhtej2 commented Mar 8, 2024

Adguard home is up to date and released 2 days ago 🤔

@Salamandar
Copy link
Contributor Author

Adguard home is up to date and released 2 days ago 🤔

hmmm indeed. i'm going to need to test this more deeply.

@Salamandar Salamandar force-pushed the deprecated branch 3 times, most recently from 396ffd5 to c290bb4 Compare March 8, 2024 18:21
@Salamandar
Copy link
Contributor Author

For me we can remove from this list a lot of html/js apps (without server side code). Specifically all games.

So at least: 20euros, 243-game, hextris, anarchism, cubiks-2048, encryptor-decryptor, filepizza, hat, osjs, simple-hash-generator, strut, trustyhash, tyto

Those apps are not really deprecated, those apps are finished and doesn't really need update for now.

I partially disagree.

Yes, some apps might keep working even though they are not developped anymore, for example anarchism. But, for example for osjs, a non-developed app might become a security issue in the (near?) future.

The issue is that we can't, as yunohost maintainers, really make that choice, except by really reading the source code…

- name: Install toml python lib
run: |
pip3 install toml tomlkit gitpython

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From contributors meeting: we need to actually run the script somewhere around here :p

@tituspijean tituspijean requested a review from alexAubin June 4, 2024 20:29
@alexAubin alexAubin changed the title Flag apps as deprecated-software with the help of a crappy script Automatically flag apps as deprecated-software with the help of a crappy script Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants