Select previously selected image when deselecting in multi-selection #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slashmo This is perfect! 🙏 Thanks a ton for taking the time to make the picker better for everybody 🎉 |
|
This is now up in https://github.com/Yummypets/YPImagePicker/releases/tag/4.0.0 🚀 |
LucasDang
pushed a commit
to pukapp/secret-ios-YPImagePicker
that referenced
this pull request
Feb 10, 2022
…lect Select previously selected image when deselecting in multi-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state
Currently, when deselecting an image in the multi-selection mode, the cell is not actually deselected. Instead it's just removed from the selection array.
Proposed change
With this PR, when deselecting an image in multi-selection mode, the current preview will be replaced by the previously selected image.