Add Token2 vendor and product definitions#924
Conversation
Added new vendor and product entries for Token2.
udev/fidodevs
Outdated
| vendor GOTRUST 0x32a3 GoTrustID Inc. | ||
| vendor UNKNOWN1 0x4c4d Unknown vendor | ||
| vendor SATOSHI 0x534c SatoshiLabs | ||
| vendor TOKEN2 0x349e Token2 Sàrl |
There was a problem hiding this comment.
It seems that vendors need to be sorted by their VID
There was a problem hiding this comment.
They should also be sorted in devices. You seem to have replaced tabs in spaces in the vendor list. I cleaned it up in token2#1
Removed duplicate vendor entries in fidodevs.
|
For completeness, please also re-generate 70-u2f.rules via Thanks for your contribution! |
Regenerate udev rules file
|
I don't think squashing commits is possible through the web UI, which is what @token2 seems to be using. However, the commits can be squashed when merging via the dropdown option. |
|
I can fix it up locally. Are you OK with me adding a |
No need to include me, but feel free if you'd like. |
|
Merged as 16746b1. |
Added new vendor and product entries for Token2.