Skip to content

Comments

Add Token2 vendor and product definitions#924

Closed
token2 wants to merge 6 commits intoYubico:mainfrom
token2:main
Closed

Add Token2 vendor and product definitions#924
token2 wants to merge 6 commits intoYubico:mainfrom
token2:main

Conversation

@token2
Copy link
Contributor

@token2 token2 commented Jan 4, 2026

Added new vendor and product entries for Token2.

Added new vendor and product entries for Token2.
udev/fidodevs Outdated
vendor GOTRUST 0x32a3 GoTrustID Inc.
vendor UNKNOWN1 0x4c4d Unknown vendor
vendor SATOSHI 0x534c SatoshiLabs
vendor TOKEN2 0x349e Token2 Sàrl
Copy link

@mimi89999 mimi89999 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that vendors need to be sorted by their VID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@token2 could you please sort it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@token2 could you please sort it?

Done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should also be sorted in devices. You seem to have replaced tabs in spaces in the vendor list. I cleaned it up in token2#1

Removed duplicate vendor entries in fidodevs.
Copy link
Contributor Author

@token2 token2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted by VID

@LDVG
Copy link
Contributor

LDVG commented Jan 9, 2026

For completeness, please also re-generate 70-u2f.rules via ./genrules.awk fidodevs > 70-u2f.rules. I'd also prefer for all of the commits in the MR to be squashed before merging.

Thanks for your contribution!

@mimi89999
Copy link

@token2 Regenerated them in token2#2

Regenerate udev rules file
@mimi89999
Copy link

I don't think squashing commits is possible through the web UI, which is what @token2 seems to be using. However, the commits can be squashed when merging via the dropdown option.

@LDVG
Copy link
Contributor

LDVG commented Jan 9, 2026

I can fix it up locally. Are you OK with me adding a Co-Authored-By: trailer with the same author/email as your commits @mimi89999?

@mimi89999
Copy link

I can fix it up locally. Are you OK with me adding a Co-Authored-By: trailer with the same author/email as your commits @mimi89999?

No need to include me, but feel free if you'd like.

@LDVG
Copy link
Contributor

LDVG commented Jan 12, 2026

Merged as 16746b1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants