"Setting up your simulation" vignette #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdunc23
reviewed
Jan 31, 2023
Contributor
jpdunc23
left a comment
jpdunc23
left a comment
There was a problem hiding this comment.
Looks good. I added a suggestion to try optparse in conjunction with bash scripts to run meal.R.
It would be good to point users to an example simulation that follows this exact structure. @PhilBoileau, can we point to one of yours?
Contributor
|
@tiffanymtang do you mind taking a pass? How do you find this suggested structure? |
Collaborator
|
Looks great! Thanks so much! @PhilBoileau |
tiffanymtang
approved these changes
Jan 31, 2023
Contributor
|
@PhilBoileau, feel free to merge when ready. |
Collaborator
Author
|
Thanks for reviewing, @jpdunc23 and @tiffanymtang! I've made some minor touch ups and have included links to existing projects that (somewhat loosely) follow the suggested setup. I'll tidy them up in the coming weeks to better align with our recommendations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the draft of a vignette instructing users on how best to organize their simulation study. Comments and suggestions welcome.