-
Notifications
You must be signed in to change notification settings - Fork 0
Access control version into master #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added users and password utilities.
Anything that currently extends modifiable should also extend Accessible WIP
getting new gitignore changes
Also fixed/updated userFactory tests. A default signing key is used for them
this will be used to keep track of access to version info items.
added tests to check if a banned user is allowed access in the detail factory. commented out some unused imports in the user factory (they threw errors when trying to run)
added detail factory tests for creating a race/class in a version that does not exist
Added access control to all the version information items
Token store problem is solved. Mostly
Access control is completed. Tests pass, merging branches
hwilling
approved these changes
May 4, 2018
Collaborator
hwilling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pls approve. See #61