Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Pkg, Examples, small var cost for storage #5

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

YoungFaithful
Copy link
Owner

  • StatsKit is not included, instead CSV, DataFrames, and StatsBase (for faster startup)
  • Storage technologies now have a very small variable cost (otherwise charging and discharging can happen in times of too high renewables)
  • Some correction in documentation
  • Examples updated

@@ -4,7 +4,7 @@ bat_e,all,2016,fix,|,3020,0
bat_e,all,2016,var,|,0,0
bat_in,all,2016,cap,|,280000,0
bat_in,all,2016,fix,|,2800,0
bat_in,all,2016,var,|,0,0
bat_in,all,2016,var,|,0.01,0
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small variable cost to prevent charge and discharge at the same time in times of renewable overproduction (Excess energy was able to be charged and discharged in the same hour without additional costs)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I always was wondering if degeneracy was occuring.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note: Did you add a sentence about this to the documentation?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thought. Added it ;)

Copy link
Owner Author

@YoungFaithful YoungFaithful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments.
Ready to be reviewed @holgerteichgraeber

Copy link
Collaborator

@holgerteichgraeber holgerteichgraeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Some comments to check in if I understand the changes correctly.

@@ -44,7 +44,7 @@ Pkg.add(PackageSpec(url="https://github.com/holgerteichgraeber/ClustForOpt.jl",
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above, there is a inconsistency .jl. JuMP.jl vs JLD2 for example.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right

README.md Show resolved Hide resolved
@@ -4,7 +4,7 @@ bat_e,all,2016,fix,|,3020,0
bat_e,all,2016,var,|,0,0
bat_in,all,2016,cap,|,280000,0
bat_in,all,2016,fix,|,2800,0
bat_in,all,2016,var,|,0,0
bat_in,all,2016,var,|,0.01,0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I always was wondering if degeneracy was occuring.

@@ -4,7 +4,7 @@ bat_e,all,2016,fix,|,3020,0
bat_e,all,2016,var,|,0,0
bat_in,all,2016,cap,|,280000,0
bat_in,all,2016,fix,|,2800,0
bat_in,all,2016,var,|,0,0
bat_in,all,2016,var,|,0.01,0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note: Did you add a sentence about this to the documentation?


# Desing with clusered data and operation with ts_full_data
# First solve the clustered case
design_result = run_opt(ts_clust_data.best_results,cep_data,optimizer;descriptor="design&operation", co2_limit=50)
design_result = run_opt(ts_clust_data.best_results,cep_data,optimizer;co2_limit=50)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check if I understand this: Basically how I see it is that the descriptor moved into the variable description? Great, that makes a lot of sense to me.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly. First users were getting a little confused, what the descriptor does...

# load cep-data
cep_data = load_cep_data_provided(state)

## CLUSTERING ##
# run aggregation with kmeans
ts_clust_data = run_clust(ts_input_data;method="kmeans",representation="centroid",n_init=5,n_clust=5) # default k-means make sure that n_init is high enough otherwise the results could be crap and drive you crazy
ts_clust_data = run_clust(ts_input_data;method="kmeans",representation="centroid",n_init=10000,n_clust=5) # default k-means make sure that n_init is high enough otherwise the results could be crap and drive you crazy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping it at 100 or 1000 and mentioning in a comment that 10000 should be used for real applications?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@YoungFaithful
Copy link
Owner Author

Implemented requests.

Copy link
Owner Author

@YoungFaithful YoungFaithful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented requests

Copy link
Collaborator

@holgerteichgraeber holgerteichgraeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge

@holgerteichgraeber holgerteichgraeber merged commit f13c0e7 into dev Apr 24, 2019
@YoungFaithful YoungFaithful deleted the singlepkg branch April 26, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants