Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dependency on ClustForOpt version #13

Merged
merged 3 commits into from
May 16, 2019
Merged

Explicit dependency on ClustForOpt version #13

merged 3 commits into from
May 16, 2019

Conversation

holgerteichgraeber
Copy link
Collaborator

Make CapacityExpansion explicitly dependent on ClustForOpt version to reduce issues when introducing breaking changes in ClustForOpt.

@holgerteichgraeber holgerteichgraeber added the enhancement New feature or request label May 14, 2019
@holgerteichgraeber holgerteichgraeber self-assigned this May 14, 2019
@YoungFaithful YoungFaithful self-assigned this May 15, 2019
This should fix it to 0.3 explicitly, right?
@YoungFaithful
Copy link
Owner

When testing is done, I'd merge.

@holgerteichgraeber
Copy link
Collaborator Author

My understanding is that ^ in project.toml is the default, so no difference between having it and not having it.

@holgerteichgraeber
Copy link
Collaborator Author

Do we need to update manifest if we fix a version through compat? I didn't do that yet.

@YoungFaithful
Copy link
Owner

Seems to be more difficult: https://julialang.github.io/Pkg.jl/v1/compatibility/
I think the manifest should be fine.

@YoungFaithful YoungFaithful merged commit 1bdf066 into master May 16, 2019
@YoungFaithful
Copy link
Owner

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

@YoungFaithful YoungFaithful deleted the compat branch November 28, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants