Skip to content

Commit

Permalink
Sass quality fixes in the LMS
Browse files Browse the repository at this point in the history
  • Loading branch information
andy-armstrong committed Oct 11, 2017
1 parent 0702df5 commit 9f0fba0
Show file tree
Hide file tree
Showing 128 changed files with 9,190 additions and 7,013 deletions.
2 changes: 2 additions & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
common/static/sass/bourbon
lms/static/sass/vendor
6 changes: 3 additions & 3 deletions lms/static/sass/_build-footer-edx.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
@import 'base/theme';

footer#footer-edx-v3 {
@import 'base/extends';
@import 'base/extends';

// base - starter
@import 'base/base';
// base - starter
@import 'base/base';
}

// base - elements
Expand Down
1 change: 0 additions & 1 deletion lms/static/sass/_build-lms-v1.scss
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@

// news
@import 'notifications';

@import 'mixins';
@import 'mixins-inherited';
@import 'elements/system-feedback';
Expand Down
17 changes: 14 additions & 3 deletions lms/static/sass/_developer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@

.ui-loading-base {
@include animation(fadeIn $tmg-f2 linear 1);

@extend %t-copy-base;

.spin {
@extend %anim-rotateCW;

display: inline-block;
}

Expand All @@ -45,6 +47,7 @@
.ui-loading {
@extend .ui-loading-base;
@extend %ui-well;

opacity: 0.6;
background-color: $white;
padding: ($baseline*1.5) $baseline;
Expand All @@ -67,20 +70,21 @@

// for verify_student/make_payment_step.underscore
.payment-buttons {

.purchase {
float: left;
padding: ($baseline*.5) 0;

.product-info, .product-name, .price {
@extend %t-ultrastrong;

color: $m-blue-d3;
}
}

.payment-button {
float: right;
@include margin-left( ($baseline/2) );

@include margin-left(($baseline/2));

&.is-selected {
background: $m-green-s1 !important;
Expand All @@ -94,12 +98,14 @@
.view-teams {
.wrapper-msg {
@include clearfix();

max-width: grid-width(12);
margin: 0 auto;
border-top: 3px solid $orange;

.left-floater {
@include float(left);

text-transform: uppercase;
font-weight: $font-semibold;
color: $white;
Expand All @@ -108,6 +114,7 @@

.right-floater {
@include float(right);

line-height: $body-line-height;

button {
Expand All @@ -126,7 +133,7 @@
}

&:focus {
box-shadow: 0 0 0 0;
box-shadow: 0 0 0 0;
}
}
}
Expand All @@ -135,6 +142,7 @@
.members-info {
margin: 0;
padding: 0;

li {
display: inline;
}
Expand All @@ -151,6 +159,7 @@
.member-info-container {
display: inline-block;
vertical-align: middle;

@include margin-left($baseline/2);

.primary {
Expand Down Expand Up @@ -191,6 +200,7 @@
//along with some "hide the inherited value, we want none" action
.prompt.warning button {
@extend %btn-no-style;

box-shadow: none;
text-shadow: none;

Expand All @@ -211,6 +221,7 @@
//along with some "hide the inherited value, we want none" action
.prompt.warning button {
@extend %btn-no-style;

box-shadow: none;
text-shadow: none;

Expand Down
Loading

0 comments on commit 9f0fba0

Please sign in to comment.