feat(jdbc): add jdbc input support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/scala/com/yotpo/metorikku/utils/TestUtils.scala
RonBarabash
requested changes
Mar 6, 2018
| override def getReader(name: String): ReadableInput = throw new UnknownInputTypeException() | ||
| } | ||
|
|
||
| trait Input { |
There was a problem hiding this comment.
@lyogev please seperate traits to different file
| } | ||
|
|
||
| trait Input { | ||
| def getReader(name: String): ReadableInput |
There was a problem hiding this comment.
@lyogev im having trouble with the names, why is it called readable input? why getReader return readable input and not reader?
| import org.apache.spark.sql.DataFrame | ||
|
|
||
| trait ReadableInput { | ||
| var name: String |
| password: String, driver: Option[String], table: String, | ||
| partitionColumn: Option[String], numberOfPartitions: Option[Int]) extends ReadableInput { | ||
| def read(): DataFrame = { | ||
| val url = connectionUrl + "?zeroDateTimeBehavior=convertToNull" |
There was a problem hiding this comment.
It's something that's only related to mysql we can move it to the client's side
There was a problem hiding this comment.
RonBarabash
previously approved these changes
Mar 13, 2018
RonBarabash
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.