Skip to content

Conversation

KrystalDelusion
Copy link
Member

@KrystalDelusion KrystalDelusion commented Sep 18, 2025

What are the reasons/motivation for this change?

A few of the CI jobs use the YosysHQ self-hosted runner. If someone makes a fork of Yosys (and enables actions), these jobs will be queued waiting for a self-hosted runner that probably doesn't exist (and if it does exist, it won't have the necessary configurations to be able to actually run Verific, which is generally what the YosysHQ self-hosted runner is used for).

Explain how this is achieved.

Jobs targeting the self-hosted runner should only run if github.repository == 'YosysHQ/Yosys'. This prevents the job from being queued on a fork entirely, without affecting PRs to this repo.

If applicable, please suggest to reviewers how they can test the change.

This PR is coming from a fork. The self-hosted jobs should run for this PR, but skip on the fork.

@KrystalDelusion KrystalDelusion self-assigned this Sep 18, 2025
@widlarizer
Copy link
Collaborator

I think we also want this for .github/workflows/update-flake-lock.yml

Copy link
Member

@mmicko mmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to merge

Prevents unintended bumps on the flake.lock and Yosys version on forks (provided the forks synchronize their main after this gets merged).
Update version.yml to use the same style of `if` on the job, rather than on specific actions.
Wheels will still build as a cron job, but won't try to upload if it's a fork.
@KrystalDelusion
Copy link
Member Author

@mmicko can you double check the changes for the other files look fine? Specifically that version.yml now uses the same style of if: github.repository at the job level instead of the steps that bump/push the change, and that wheels.yml is okay to build_wheels but upload_wheels checks the repo.

Copy link
Member

@mmicko mmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cleaner now. Agree that there is no need to do any work for some tasks unless they are on this exact repo, so jobs level check is better in that case

@KrystalDelusion KrystalDelusion merged commit 991561f into YosysHQ:main Sep 23, 2025
27 checks passed
@KrystalDelusion KrystalDelusion deleted the krys/yosyshq-only-jobs branch September 23, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants