Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one small commit on top of #5315. That commit removes
design->sort();
from all passes that unconditionally run it. I believe Yosys is deterministic with reproducible results with or without those. If abc isn't, then that's a more impactful problem than can be saved by sorting at any point in the flow.The only test that ultimately has to be fixed with this change is
tests/arch/xilinx/dsp_cascade.ys
where the reordering of the design changes the count of someFDRE
primitives received by synthesis. This change also greatly increases the runtime ofequiv_opt
in that one test despite the size of the SAT problem being exactly the same. Reduced reproducer for this slowdown:This speeds up running synth on jpeg by 5%, tested with 3 different values for
--hash-idx
. It also likely makes--hash-idx
a more powerful hyper-optimization input.