dfflibmap: propagate negated next_state to output correctly #5190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widlarizer
force-pushed
the
emil/dfflibmap-fix-negated-next_state
branch
from
71afe0c to
5d8fa56
Compare
widlarizer
force-pushed
the
emil/dfflibmap-fix-negated-next_state
branch
from
5d8fa56 to
778079b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5186. Prior to this PR, a negation in next_state was considered equivalent to an inverter on the output port. However, flops with set or reset need swapping.
_DFFSR_*with set or reset are still mapped correctly as well