Skip to content

const2ast: prove tests cover error filenames #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

const2ast: prove tests cover error filenames #5181

wants to merge 1 commit into from

Conversation

widlarizer
Copy link
Collaborator

The deletion of uses of the AST layer global state member current_filename should be caught by tests. I will close this draft PR when rebasing onto main makes the tests fail.

we have mutation testing at home
mutation testing at home:

@widlarizer widlarizer mentioned this pull request Jun 16, 2025
Open
@widlarizer
Copy link
Collaborator Author

They'll get removed in #5135 as they are definitely no longer needed there

@widlarizer widlarizer closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachjs zachjs Awaiting requested review from zachjs zachjs will be requested when the pull request is marked ready for review zachjs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@widlarizer