Add ASAN to CI #5180
Open
Add ASAN to CI #5180
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New matrix variable for sanitizer, running `undefined` and `address` separately (because they are mutually exclusive). Probably don't need to run both sanitizers on both os targets, but it's probably fine.
mmicko
approved these changes
Jun 19, 2025
|
FYI this is failing CI because of a memory issue introduced by #5152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
We have UBSAN running on CI, but sometimes ASAN issues slip through as well (e.g. #5020, #5163).
Explain how this is achieved.
Define the sanitizer as part of the test strategy matrix in the
test-build.ymlfamily of CI jobs.There are still memory leaks being picked up in the Verific tests, but I added a (hopefully temporary) patch to
tests/verific/run-test.shto disablehalt_on_errorfor the tests in that directory. The sanitizer builds are running on the open source runner, so they shouldn't actually hit the Verific tests anyway, but better safe than sorry.If applicable, please suggest to reviewers how they can test the change.
CI should pass, having run the test suite with ASAN.