opt_dff: don't remove cells until all have been visited to prevent UAF #5165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix doesn't actually work yet as it turns out |
|
Ok I've fixed the further issue with emitting cells so this is ready for review. |
KrystalDelusion
approved these changes
Jun 20, 2025
KrystalDelusion
added
the
merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Fixes #5164.
Explain how this is achieved.
Instead of removing and emiting changed cells as they are found no longer needed, cache them and remove/emit afterwards to prevent invalidating the Cell*s in ModWalker.
If applicable, please suggest to reviewers how they can test the change.
Added a testcase from #5164 that fails with an ASAN build before this change.