simplify: Skip AST_PRIMITIVE in AST_CELLARRAY #4959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the `AST_PRIMITIVE` simplifies to the corresponding function and is no longer caught by the check for `AST_PRIMITIVE`s, raising an assertion error instead of an input error. Add bug4785.ys to tests/verilog to demonstrate.
|
As pointed out in #4785, wrapping the primitive in a module, and then using an array of the wrapper module works fine. So it may be possible to implement support for cell arrays of primitives, but I'm not sure how much work that is. And there was already an error message for them being unsupported so 🤷 At least raising the proper error makes it clear we don't support it, rather than the mystery of an assertion error. |
|
@zachjs could you review this PR 🙏 |
zachjs
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Close #4785.
We have an input error about cell arrays of primitives not being supported, but the
AST_PRIMITIVEis simplified before it can be checked, leading to an assertion error instead.Explain how this is achieved.
Don't simplify
AST_PRIMITIVEinAST_CELLARRAY, similar to #3467.If applicable, please suggest to reviewers how they can test the change.
Run
yosys tests/verilog/bug4785.yswith/without this patch.