Allow whitespace in tee command paths
#4619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure why that one job is failing, but it seems unrelated to my changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Currently,
tee -o "test file"creates a file literally named"test file". This essentially makes it impossible to indicate files/paths that include whitespace without adding the literal quotes.Explain how this is achieved.
Uses
void rewrite_filename(std::string &filename)to rewrite the path. As a nice side effect, ~/tilde paths are now expanded as well.If applicable, please suggest to reviewers how they can test the change.
Just try
tee -o "test file"before and after.