New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add code to resolve issue #15" #17

Merged

YoongiKim merged 1 commit into master from revert-16-junho

Jan 4, 2020

+0 −0

Owner

YoongiKim commented Jan 4, 2020

Reverts #16

I checked it. But this code cannot run safe on the situation:

All the variables about number is set to 1000 not infinite.
If the downloading fails in the collecting links, the total count will be less than max_number.
So collect_link should be same but limiting the downloading count (not collecting links).


          Revert "add code to resolve issue #15"

60075d5

YoongiKim merged commit ad57fe9 into master

YoongiKim deleted the revert-16-junho branch

January 4, 2020 16:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet