Fix the scale-2 variant and phase out pzoo #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Answers #276, but due to legacy I'm reluctant to remove the pzoo statefulset. We'll keep using regional storage for zoo and zone-specific storage for pzoo. Also I've been in upgrade situations where it helped to have two statefulsets in order too keep the quorum capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With storage class name abstracted out (#270) there's no reason other than backwards compatibility to keep pzoo. Except maybe if it helps in maintenance situations. Scaling zookeeper is a bit tricky due to all pods containing a static list of zk instances' DNS names.
I think this fixes #276, which is a duplicate of #123.