Make the values endpoint streaming again #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of #48 and also raises an overdue review question if we can retrieve offsets after we've streamed the values. I think so but that probably depends on threads.
atamon
approved these changes
Sep 15, 2023
It's a gotcha with StreamingOutput that if you also add headers it's written (by this JAX-RS impl?) as entity.toString
|
Replaced by #51 which is a smaller diff and keeps test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids memory usage spikes when retrieving large values responses. Reverts parts of #48 but also reduces the test coverage that #48 introduced. I found no easy way to render a response body from the "entity" and I didn't feel like introducing a REST test framework for this change.