-
Notifications
You must be signed in to change notification settings - Fork 3
Redesign for use as sidecar #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./mvnw package -Pnative -Dnative-image.docker-build=true
with zstd-jni 1.3.8-1 in case anyone's interested
There's a MicroConfig readiness concept that I didn't have time to investigate
ConsumerAtLeastOnceIntegrationTest.testTopicNonexistent » Timeout Timeout expi...
for example application:se_yolean_kafka_keyvalue_consumer_at_least_once_ so we don't need to add any context to names
but luckily we're single threaded
so client app can fetch state prior to becoming ready to receive updates Also make error logging a bit more bearable.
…ssions Snappy in this case, and possibly z-standard
the wrapper script. Java 11 should be container friendly by default.
mechanism for setting arbitrary kafka props. This one we'll likely want to change on a per use-case basis.
whenever there's metrics annotations
Scoped out metrics in 42d19b5. I might try to revert that once Quarkus has upgraded to Graal 19. |
There was a kafka client upgrade in master that we've never used and never will use so I force pushed to avoid the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's explore how/if we can simplify the design when only scoping in use as a sidecar. One major difference is that we don't need to send "onupdate" to multiple replicas of dependent services.
Design:
Questions: