Fix visited link color for ai-primary and ai-secondary buttons - #23567
Open
JorPV wants to merge 1 commit into
Open
Fix visited link color for ai-primary and ai-secondary buttons#23567JorPV wants to merge 1 commit into
JorPV wants to merge 1 commit into
Conversation
Coverage Report for CI Build 0Coverage remained the same at 56.632%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
ai-primaryandai-secondaryButton variants in@yoast/ui-librarydidn't account for the browser's default:visitedlink styling when renderedlinktag. Once clicked, the anchor's text color fell back to the browser's default visited-link color.Summary
ai-primaryandai-secondarybutton variants would change to the browser's default visited-link color when the button was rendered as a link.Relevant technical choices
visited:andvisited:hover:Tailwind utilities to both AI variants: mirrors the pattern already used by every other button variant, keeping AI buttons consistent when rendered as links.Test instructions for the acceptance test before the PR gets merged
yarn storybookand openhttp://localhost:6006.astoaandvarianttoai-primary.variantset toai-secondary, confirming the text stays dark slate instead of white.Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
Affects the
Buttoncomponent in@yoast/ui-library(ai-primaryandai-secondaryvariants), used anywhere these buttons render as links across Free/Premium.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces new images or SVGs.Innovation
Fixes Yoast/reserved-tasks#1319