Skip to content

Announce the addition of the Google docs add on to Free & Premium #4603 #22309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mykola
Copy link
Contributor

@mykola mykola commented May 27, 2025

Context

  • Announce the addition of the Google docs add on to Free & Premium.

Summary

This PR can be summarized in the following changelog entry:

  • Announces the addition of the Google docs add on to Free & Premium.

Relevant technical choices:

  • GoogleDocsAddonUpsell component added to implement this. It Content required to be wrapped in Modal to be displayed correctly. IsPremium at some pages we can take only from wpseoIntroductions object so it's used.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Free.

  • Deactivate Yoast Premium plugin if it's active.
  • Open Yoast Test plugin and click Reset First time configuration progress.
    image
  • Deactivate and the free plugin.
  • Open any sql editor or use wp db query wp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:
    DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions'
  • Activate the free plugin.
  • Make sure that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed and fit the design:
    image
  • Click on Unlock with Yoast SEO Premium button and make sure that url is opened in new tab (the pages should be created and active before tests).

Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Premium.

  • Deactivate Yoast Premium plugin if it's active.
  • Open Yoast Test plugin and click Reset First time configuration progress.
  • Open plugins page.
    image
  • Open any sql editor or use wp db query wp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:
    DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions'
  • Activate the premium plugin.
  • Make sure that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is not displayed and fit the design:
    image
  • Click on Get started for free button and make sure that url is opened in new tab (the pages should be created and active before tests).

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • Should not impact other places.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #4603

@mykola mykola added the UI change PRs that result in a change in the UI label May 27, 2025
@mykola mykola added this to the 25.3 milestone May 27, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 119fc61724a33762dcb3892e0df877fc30b32205

Details

  • 3 of 30 (10.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 52.768%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/introductions/initialize.js 0 1 0.0%
packages/js/src/shared-admin/components/google-docs-addon-upsell.js 3 6 50.0%
packages/js/src/introductions/components/content.js 0 11 0.0%
src/introductions/application/google-docs-addon-upsell.php 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/introductions/initialize.js 1 0.0%
Totals Coverage Status
Change from base Build d51584948daa306f55e437e459c53f16647f62be: 0.5%
Covered Lines: 29690
Relevant Lines: 57512

💛 - Coveralls

@mykola mykola marked this pull request as ready for review May 27, 2025 07:04
@hannaw93 hannaw93 removed this from the 25.3 milestone May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants