Fix eye icons

[pls78]

Context

• We want to restore the EyeOffIcon and EyeIcon in their original position.

Summary

This PR can be summarized in the following changelog entry:

• Fixes misplaced EyeIcon and EyeOffIcon position.

Relevant technical choices:

• N\A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Go to Yoast SEO - General
• Make sure you have at least one problem and one notification in the Alert center
• Verify that:
  • if the alert is visible, the EyeOffIcon is shown beside it
  • if the alert is hidden, the EyeIcon is shown beside it

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• N\A

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #21701

[coveralls]

Pull Request Test Coverage Report for Build 1fe549ed412506d1939964550b94477b49de1fa4

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 49.389%

---

Totals
Change from base Build 5fe591e4aa7b2ab8e1b7e72a52790da7a6376543:	0.0%
Covered Lines:	25666
Relevant Lines:	53666

---

💛 - Coveralls

[thijsoo]

CR + ACC 👍