Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of price in BF sidebar ad #21680

Merged

Conversation

igorschoester
Copy link
Member

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes the mention of price in the Black Friday sidebar ad in the Yoast admin pages.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure Yoast Premium is not active.
  • Enable Black Friday promotion by editing src/promotions/domain/black-friday-promotion.php replace line 16:
new Time_Interval( \gmmktime( 12, 00, 00, 11, 28, 2023 ), \gmmktime( 12, 00, 00, 12, 3, 2024 ) )
  • Go to the General admin page
  • Look at the sidebar
  • Verify the price is no longer showing below the buy button
image
  • You can verify the same for the other PHP admin page: Tools. However, it uses the same code.
  • Go to the Settings admin page
  • Look at the sidebar
  • Verify the price is no longer showing below the buy button
image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/287

@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 2, 2024
@igorschoester igorschoester added this to the 23.6 milestone Oct 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1afcf4a344effbf88a8764347aaed127659f31a7

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 287-remove-mention-of-price-in-bf-sidebar-ad at 41.928%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/presenters/admin/sidebar-presenter.php 0 2 0.0%
Totals Coverage Status
Change from base Build e1a1161e941b3aef14a56db014efd1f9ea9e40c4: 41.9%
Covered Lines: 20103
Relevant Lines: 44582

💛 - Coveralls

@enricobattocchi enricobattocchi merged commit 8505a90 into release/23.6 Oct 3, 2024
34 of 35 checks passed
@enricobattocchi enricobattocchi deleted the 287-remove-mention-of-price-in-bf-sidebar-ad branch October 3, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants