Refactor Black Friday: remove code and reword

[igorschoester]

Context

• We no longer want the promo code.

Summary

This PR can be summarized in the following changelog entry:

• Removes the promo code from the Black Friday sale.

Relevant technical choices:

• Reverted Adds promo code to upsell ad in upsell modals #21674

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Make sure Yoast Premium is not active.
• Enable Black Friday promotion by editing src/promotions/domain/black-friday-promotion.php replace line 16:

new Time_Interval( \gmmktime( 12, 00, 00, 11, 28, 2023 ), \gmmktime( 12, 00, 00, 12, 3, 2024 ) )

• Edit a post
• Look at the top of the SEO tab in the metabox
• Verify the promo code is no longer there, and we mention Black Friday again

• Look at the top of the Yoast sidebar
• Verify the promo code is no longer there, and we mention Black Friday again

• Click on the "Premium SEO analysis"
• Verify the promo code is no longer there

• You can verify the same for "Add related keyphrase", "Internal linking suggestions" and under SEO analysis: "+ Add synonyms" and "+ Add related keyphrase". However, they use the same code.
• Go to the General admin page
• Look at the footer
• Verify the promo code is no longer there, and we mention Black Friday again

• Look at the sidebar
• Verify the promo code is no longer there, and we mention Black Friday again

• You can verify the same for the other PHP admin page: Tools. However, it uses the same code.
• Go to the Settings admin page
• Look at the footer
• Verify the promo code is no longer there, and we mention Black Friday again

• Look at the sidebar
• Verify the promo code is no longer there, and we mention Black Friday again

• Look at the admin bar
• Verify the promo code is no longer there

• Go to the Upgrades aadmin page
• Verify the promo code is no longer there, and we mention Black Friday again

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• [ x] I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/284

[coveralls]

Pull Request Test Coverage Report for Build 641f1b996071cc807985e0ec6f2fe6a66858219e

Details

• 0 of 6 (0.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.001%) to 54.498%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
admin/views/licenses.php	0	1	0.0%
inc/class-wpseo-admin-bar-menu.php	0	1	0.0%
src/presenters/admin/sidebar-presenter.php	0	1	0.0%
admin/class-premium-upsell-admin-block.php	0	3	0.0%

Totals
Change from base Build 18d6ee78eb26e5007497a03ad7051076d23fd8a6:	-0.001%
Covered Lines:	29530
Relevant Lines:	54457

---

💛 - Coveralls

[vraja-pro]

CR & AC ✅