Non-WP-Upload directory Logo URL

[gr8shivam]

• [.] I've read and understood the contribution guidelines.
• [.] I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

Users using an Organisation Logo Image from a URL outside the WP uploads folder won't get Organisation schema since it fails in fetching the Attachment ID in https://github.com/Yoast/wordpress-seo/blob/trunk/frontend/schema/class-schema-context.php#L198

In the newer versions, option to add a custom URL is not available. But for users using the URL from previous versions are affected by this issue.

Please describe what you expected to happen and why.

Users using the Logo image from a directory outside WP-Uploads directory should be shown a notice to use an image from WP Media Library.

How can we reproduce this behavior?

1. Use Organisation Logo image from any directory outisde WP uploads folder like an image from Theme directory.
2. The organisation schema won't show since the Attachment ID will be 0.

Technical info

• WordPress version: All versions
• Yoast SEO version: All versions, but only for users who are using from previous versions

[Djennez]

I was able to reproduce the issue. The solution is to use that media uploader (as you've clarified yourself). I am not sure if adding a notification is a possibility, and if it is, if it will get priority.

[gr8shivam]

The user is unaware of the fact that the Organization Schema is not shown because of using the Non-WP-Uploads directory URL.

A simple notice under Problems section in Dashboard can help him/her change that.

[gr8shivam]

I'm working on building a fix for this issue. Is a notification function like wordpress_upgrade_notice() inside admin-init recommended or a separate class like class-schema-person-upgrade-notification?

[igmoweb]

Why, instead of a notification, not saving the thumbnail ID? This would not require to store a URL but the reference to the attachment and then use WP functions to retrieve the URL.