Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Create plural diminutives in Dutch #425

Closed
wants to merge 7 commits into from
Closed

Create plural diminutives in Dutch #425

wants to merge 7 commits into from

Conversation

agnieszkaszuba
Copy link
Contributor

@agnieszkaszuba agnieszkaszuba commented Dec 17, 2019 •
edited by nataliashitova
Loading

Summary

This PR can be summarized in the following changelog entry:

  • [yoastseo] Creates a plural form of each diminutive noun form in Dutch. For example, it creates not only katje from kat, but also katjes.

Test instructions

This PR can be tested by following these steps:

  • Add more tests to the specs. For each test, specify the stem of a noun, together with the expected noun forms, including plural diminutives. In case of uncertainty regarding what the stem of the noun would be, it can be checked using the function in src/morphology/dutch/stem.js

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #424

@agnieszkaszuba agnieszkaszuba mentioned this pull request Dec 17, 2019
Open
@agnieszkaszuba agnieszkaszuba changed the base branch from feature/Dutch-morphology to develop December 17, 2019 15:27
@agnieszkaszuba agnieszkaszuba changed the base branch from develop to feature/Dutch-morphology December 17, 2019 15:27
manuelaugustin
manuelaugustin suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@manuelaugustin manuelaugustin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Looks good overall! I just have some small changes to propose 🙂

@nataliashitova nataliashitova added this to the Dutch morphology milestone Feb 25, 2020
@IreneStr IreneStr deleted the 424-dutch-diminutive-plurals branch September 17, 2020 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manuelaugustin manuelaugustin manuelaugustin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dutch morphology
Development

Successfully merging this pull request may close these issues.
3 participants
@agnieszkaszuba @manuelaugustin @nataliashitova