Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Set node version in .travis.yml to 10.16 #382

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

IreneStr
Copy link
Contributor

@IreneStr IreneStr commented Oct 22, 2019

The current LTS in Travis is 12.13, but our node-sass is not compatible with that.

Summary

This PR can be summarized in the following changelog entry:

  • N/A

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • See the travis builds succeed.

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    • None

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@IreneStr IreneStr added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 22, 2019
@IreneStr IreneStr force-pushed the set-travis-node-version-to-10.16 branch 2 times, most recently from a3e4283 to 4c4d1b8 Compare October 22, 2019 11:33
The current LTS in Travis is 12.13, but our node-sass is not compatible with that.
@IreneStr IreneStr force-pushed the set-travis-node-version-to-10.16 branch from 4c4d1b8 to 393c7e1 Compare October 22, 2019 11:37
@IreneStr IreneStr merged commit a0bce48 into develop Oct 22, 2019
@IreneStr IreneStr deleted the set-travis-node-version-to-10.16 branch October 22, 2019 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant