-
Notifications
You must be signed in to change notification settings - Fork 53
Add an Alert component #349
Add an Alert component #349
Conversation
This component is not managed. Meaning the dismiss functionality should be added outside.
99e37d9
to
a60938e
Compare
* Use `×` as dismiss icon. * Overwrite the content's anchor color. * Moved the colors to the style guide repo.
CR Done 👍 |
About the translatable string in the default prop, see for example Yoast/wordpress-seo#11705 (comment) Seems the default needs to be provided within the render. |
I made several changes so I think it's better someone else does final acceptance. Will move back to the proper lane. Screenshots: Single line Multiple lines and focus style for the dismiss button. This is based on the provided design on https://github.com/Yoast/design/issues/392#issuecomment-515051908
Note: It is not possible to make the dismiss button alignment have a pixel-perfect alignment because:
Noted on the design issue, pending feedback. In the plugin: In the last screenshot you can clearly see the vertical alignment is different. The only reason for this is the font face internal metrics. As noted in the design issue, the only option I can think of to avoid this is to use an SVG icon. |
Re the |
Acceptance: 👍 |
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Impact check
*
Screenshot
UI changes
Quality assurance
Partially fixes: Yoast/wordpress-seo#13173