refactor(client): clean up codex module #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #532
Applied changes based on Issue #532.
I’ve refactored src/client/codex.ts to pull out and simplify the core steps into three small helpers—argument‑building, env‑building, and output‑parsing—and cleaned up the main
runCodex
flow. Here’s what changed:Extracted helpers
buildCliArgs(prompt, model, images)
usesflatMap
for image flags and assembles the full argument list.buildEnvVars(config)
centralizes all environment‑variable setup via object spreads.extractCodexOutput(stdout)
splits on newlines, finds the second‑last/last timestamp markers via a singlereduce
, and returns the trimmed block.Streamlined
runCodex
extractCodexOutput(result.stdout)
.Maintained identical behavior
All existing logging, error types (
CliError
,TimeoutError
), and timestamp‑block logic remain functionally unchanged—just reorganized for clarity and performance.Please let me know if any tweaks are needed!