refactor(github/comments): simplify comments module #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537
Applied changes based on Issue #537.
I’ve refactored src/github/comments.ts to improve clarity and modularity while preserving its existing behavior:
What Changed
GitHubError
.isIssueEvent
/isReviewCommentEvent
) for clear narrowing of theGitHubEvent
union.postIssueComment
for creating issue/PR comments via the issues API (with truncation and logging).postReviewReply
for replying to PR review comments, with a built‑in fallback to a regular PR comment.postComment
to simply dispatch to those helpers via early‐returns, flattening nestedif
/try
blocks.upsertComment
to use the same issue‐vs‐PR branching via early‐returns and invokepostComment
as needed.No behavioral changes were introduced—just clarity, DRY‑ness, and more idiomatic TypeScript. Let me know if you’d like any further tweaks!