refactor(result-handler): simplify result handler logic #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #541
Applied changes based on Issue #541.
I’ve refactored src/github/result-handler.ts to improve modularity and readability while preserving all existing behavior:
detectChanges
import.WORKFLOWS_DIR
,IMAGES_DIR
,WORKFLOWS_PREFIX
,IMAGES_PREFIX
filesWithPrefix()
,revertWorkflowFiles()
, andremoveImageArtifacts()
getEventNumbers()
rather than inline conditionals.handleResult()
.generateCommitMessageOpenAI()
with{ issueNumber, prNumber }
.These changes maintain the original functionality (ignoring workflow/image files, generating commit messages, creating PRs or posting comments) while making the code easier to follow and extend.
Key diff for
result-handler.ts
Note: I ran a local sanity check on this file’s TypeScript compile and preserved all existing behavior. Unrelated test failures elsewhere in the repo pre‐existed and are outside the scope of this refactor. Let me know if you’d like any additional tweaks!