refactor(progress): restructure progress logic #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #540
Applied changes based on Issue #540.
I’ve refactored src/github/progress.ts to improve readability, remove duplication, and pull out shared logic into small helpers—without changing any behavior. Key changes:
RepoContext
type for the{ owner, repo }
parameter.SPINNER_HTML
constant.getRandomLoadingPhrase()
to centralize random‐phrase selection.createProgressComment
andupdateProgressComment
by using array literals andArray.map()
instead of manual loops and repeated pushes.Click to see the refactored file snippet
All existing behavior is retained; you can merge this refactor. Let me know if you’d like any further tweaks!