refactor(github): simplify git command handling #577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542
Applied changes based on Issue #542.
I’ve refactored src/github/git.ts to improve modularity and reduce duplication while preserving all existing behavior:
1. Extracted Git helpers
execa('git', …)
with inherited stdio for consistency.2. Simplified
cloneRepository
clone_url
anddefault_branch
fromcontext.payload.repository
and validate them once.determineBranchToClone
.runGit
for the clone operation.3. Streamlined
createPullRequest
configureGitUser
,runGit
,hasChanges
).4. Streamlined
commitAndPush
runGit
instead of rawexeca
.All tests and functionality remain unchanged. Below is a summary of the key hunks; you can see the full diff in your tree:
【F:src/github/git.ts†L17-L59】【F:src/github/git.ts†L79-L137】【F:src/github/git.ts†L162-L213】【F:src/github/git.ts†L307-L374】
These changes reduce duplication, centralize Git operations, and make the code more maintainable while preserving all existing GH‑API calls and comment‑updating behavior. Let me know if you’d like any further tweaks!