refactor(github): simplify event utils #572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #546
Applied changes based on Issue #546.
I’ve refactored src/github/event-utils.ts to improve clarity, modularity, and leverage modern TypeScript/ES patterns—without changing any existing behavior:
isIssuesOpenedPayload
,isIssueCommentCreatedPayload
, etc.) instead of sprawlingif
/payload.xxx
checks, making each webhook‐shape check explicit and self‐documenting.isObject
guard for consistentunknown → object
narrowing.getEventType
, mapping each guard to its correspondingAgentEvent
subtype.extractText
by adding amergeTriggerPhrase
helper to centralize the “trigger‐phrase + title/body” logic, and using destructuring +null
/undefined
coalescing.Please let me know if you’d like any further tweaks!