refactor(github-utils): simplify helper functions #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #545
Applied changes based on Issue #545.
I’ve refactored src/github/utils.ts to improve readability, modularity, and maintainability while preserving all existing behavior. Key changes:
BranchType
union type to clearly define the allowed branch prefixes rather than returning a plain string.BRANCH_TYPE_PATTERNS
,NON_ALPHANUMERIC_REGEX
,TRIM_DASHES_REGEX
,MAX_OUTPUT_LENGTH
) so patterns are compiled once and meaningfully named.getBranchType
to use a lookup overBRANCH_TYPE_PATTERNS
instead of multiple inline regex tests.truncateOutput
to accept an optionalmaxLength
parameter (defaulting toMAX_OUTPUT_LENGTH
) and switched fromsubstring
toslice
for consistency.The patch was applied in place:
【F:src/github/utils.ts†L1-L66】
Please let me know if you’d like any further tweaks!