refactor(utils): simplify flag handling #569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #552
Applied changes based on Issue #552.
I’ve refactored src/utils/flags.ts to improve type safety, readability, and performance while preserving all existing behavior:
parseFlags
so the returnedflags
map is strongly‑typed to the literal keys you pass in.Set
instead of repeatedArray.includes
in the token loop.Object.fromEntries
rather than manual.forEach
.DIRECT_FLAGS
/TRIGGER_FLAGS
) to top‑levelconst as const
arrays, enabling literal inference.extractPromptFlags
for a concise mapping to the output shape.Diff of src/utils/flags.ts:
All functionality remains identical; lookups are now faster, types are safer, and the code is more concise and maintainable. Let me know if any further tweaks are needed!